Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/go: flaky TestScript/test_regexps failure #36664
Noticed in a trybot run, sandwiched between a bunch of commits in which the test passed.
gopherbot pushed a commit to golang/tools that referenced this issue
Jan 22, 2020
While investigating golang/go#36664, the entire output of a failure could get pretty long - past fifty lines of content. I was getting confused as to why the output was being cut off. I had to discard a number of theories (the test being buggy, my expected output being wrong, etc) before I realised that something was truncating the output for the sake of the reader. Since that's what stress is doing, make it add an ellipsis character too, to further hint to the user that the output is being truncated for readability. Separate it with a newline to make it easier to notice. Change-Id: Ie052c13bb48d6fd842d6054848161266d9ea17e6 Reviewed-on: https://go-review.googlesource.com/c/tools/+/215597 Run-TryBot: Daniel Martí <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> Reviewed-by: Bryan C. Mills <email@example.com>