Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: cmd/gitmirror not mirroring proposal repository #36682

Closed
ianlancetaylor opened this issue Jan 21, 2020 · 4 comments
Closed

x/build: cmd/gitmirror not mirroring proposal repository #36682

ianlancetaylor opened this issue Jan 21, 2020 · 4 comments
Assignees
Milestone

Comments

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Jan 21, 2020

The most recent changes to https://go.googlesource.com/proposal are not being mirrored to https://github.com/golang/proposal. The latest change on the latter is from October 23, 2019. The lasest change on the former is from today (January 21, 2020).

CC @toothrot @dmitshur

@gopherbot gopherbot added this to the Unreleased milestone Jan 21, 2020
@gopherbot gopherbot added the Builders label Jan 21, 2020
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jan 21, 2020

Looking. farmer.golang.org is currently reporting that gitmirror status is "ok". Something must be wrong.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jan 21, 2020

From logs:

2020/01/17 18:02:20 Not mirroring repo proposal

This might be a misconfiguration.

@dmitshur dmitshur self-assigned this Jan 21, 2020
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jan 21, 2020

More repos that aren't being mirrored from logs:

2020/01/17 18:02:20 Not mirroring repo grpc-review
2020/01/17 18:02:20 Not mirroring repo gollvm
2020/01/17 18:02:20 Not mirroring repo sublime-build
2020/01/17 18:02:20 Not mirroring repo proposal
2020/01/17 18:02:20 Not mirroring repo sublime-config

However, they should be mirrored per https://github.com/golang/build/blob/d3fb66653c7bebb6834247367b68f647100d98b5/repos/repos.go#L55-L58.

cmd/gitmirror was last deployed 46 days ago. I think it just needs to be redeployed to pick up the changes from CL 210461 where "proposal" and other repos were added to be mirrored. /cc @bradfitz

I'll do that now.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jan 21, 2020

After redeploying:

2020/01/21 22:42:43 Not mirroring repo grpc-review
2020/01/21 22:42:43 Not mirroring repo gollvm

This is consistent with the configuration in the latest version of the golang.org/x/build/repos package (see here).

The proposal, sublime-build, and sublime-config repos should be mirrored now. I'll close this as resolved, but please let me know if there's anything more to do here.

@dmitshur dmitshur closed this Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.