Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bytes: TestGrow is flaky #36695

Closed
bcmills opened this issue Jan 22, 2020 · 6 comments
Closed

bytes: TestGrow is flaky #36695

bcmills opened this issue Jan 22, 2020 · 6 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 22, 2020

2020-01-19T20:36:10-df2999e/android-arm-corellium

See previously #24647. The fix for that issue (in CL 104235) only seems to have been applied to the strings package, not bytes — it probably just needs to be ported over.

(CC @dmitshur @toothrot @cagedmantis)
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Jan 22, 2020
@bcmills bcmills added this to the Backlog milestone Jan 22, 2020
@bradfitz
Copy link
Contributor

bradfitz commented Jan 22, 2020 •
edited
Loading

There is no bytes.Builder. (And no TestBuilderGrow)

@bradfitz bradfitz changed the title bytes: TestBuilderGrow is flaky bytes: TestGrow is flaky Jan 22, 2020
@bcmills
Copy link
Contributor Author

bcmills commented Jan 22, 2020 •
edited
Loading

Correct, but the problem we fixed with the strings.Builder test maps cleanly onto the corresponding bytes.Buffer test.

@howjmay
Copy link
Contributor

howjmay commented Jan 23, 2020

May I give it a try?

@bcmills
Copy link
Contributor Author

bcmills commented Jan 23, 2020

@howjmay, sure!

howjmay added a commit to howjmay/go that referenced this issue Jan 24, 2020
@howjmay
fix: Fix flaky test TestGrow
16abea3 
fixes golang#36695
@howjmay howjmay mentioned this issue Jan 24, 2020
Closed
howjmay added a commit to howjmay/go that referenced this issue Jan 24, 2020
@howjmay
bytes_test: Fix flaky test TestGrow
037af92 
fixes golang#36695
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/216237 mentions this issue: bytes_test: Fix flaky test TestGrow

howjmay added a commit to howjmay/go that referenced this issue Jan 24, 2020
@howjmay
bytes_test: Fix flaky test TestGrow
6a7fba6 
fixes golang#36695
howjmay added a commit to howjmay/go that referenced this issue Jan 24, 2020
@howjmay
bytes_test: Fix flaky test TestGrow
9519355 
fixes golang#36695
@howjmay howjmay mentioned this issue Jan 24, 2020
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/216238 mentions this issue: bytes_test: Fix flaky test TestGrow

howjmay added a commit to howjmay/go that referenced this issue Jan 24, 2020
@howjmay
bytes_test: Fix flaky test TestGrow
e00c52c 
fixes golang#36695
howjmay added a commit to howjmay/go that referenced this issue Feb 8, 2020
@howjmay
bytes_test: fix flaky test TestGrow
e6ca6d8 
Use testing.AllocsPerRun to measure allocations in TestGrow.
With testing.AllocsPerRun, the influence made by garbage collection
would play a minor role for running test for multiple times.
fixes golang#36695
howjmay added a commit to howjmay/go that referenced this issue Feb 8, 2020
@howjmay
src/bytes_test: fix flaky test in TestGrow
c2fb1f7 
Use testing.AllocsPerRun to measure allocations in TestGrow.
With testing.AllocsPerRun, the influence made by garbage collection
would play a minor role for running test for multiple times.

Fixes golang#36695
@golang golang locked and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Backlog
4 participants
@bradfitz @bcmills @gopherbot @howjmay