x/tools/gopls: race in updateAnalyzers #36699
Closed
Milestone
Comments
I'm actually not sure how to fix this effectively since all of the fields in the options are exported. |
I set |
After offline discussion with @ianthehat, @heschik will look into the possibility of setting |
#36872's logs actually show the other side of the race:
|
Change https://golang.org/cl/216844 mentions this issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Seen on CL 215743, which was not related.
This is specific to the tests in
golang.org/x/tools/gopls/test
, because they pass an options modification function (with the signaturefunc(*source.Options)
) that updates the analyzers map. All of the command tests use this type of function, but only the gopls/test ones modify a map. A possible solution would be to have a mutex on the options before modifying them.The text was updated successfully, but these errors were encountered: