Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: handle replace directives #36745

Closed
stamblerre opened this issue Jan 24, 2020 · 1 comment
Closed

x/tools/gopls: handle replace directives #36745

stamblerre opened this issue Jan 24, 2020 · 1 comment
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jan 24, 2020

We watch all of the files in the module root for changes on-disk, and we also use changes to the current module as a heuristic for when it's necessary to rescan for imports. We should also track replace directives and watch file changes in replace targets.

@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Jan 24, 2020
@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.5.0 Mar 12, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v0.6.0 Apr 2, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.6.0, gopls/v0.5.0 Jun 24, 2020
@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Jul 14, 2020

Fixed as of CL 239198, though VS Code does not support watching directories outside of the workspace root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.