Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: ad-hoc packages not showing diagnostics #36753

Closed
stamblerre opened this issue Jan 24, 2020 · 1 comment
Closed

x/tools/gopls: ad-hoc packages not showing diagnostics #36753

stamblerre opened this issue Jan 24, 2020 · 1 comment
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jan 24, 2020

A combination of https://golang.org/cl/216143 and https://golang.org/cl/216141 has resulted in ad-hoc packages not getting any diagnostics at all. Also, the out of module/out of GOPATH warning doesn't seem to show up anymore. Investigate why (is it maybe better for ad-hoc packages to get no warnings at all)?

@stamblerre stamblerre added this to the gopls/v0.3.0 milestone Jan 24, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jan 25, 2020

Change https://golang.org/cl/216307 mentions this issue: internal/lsp: handle metadata reloads for ad-hoc packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.