Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: adding a test causes overlay errors to linger #36754

Closed
stamblerre opened this issue Jan 24, 2020 · 1 comment
Closed

x/tools/gopls: adding a test causes overlay errors to linger #36754

stamblerre opened this issue Jan 24, 2020 · 1 comment
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jan 24, 2020

The example given in #36635 mostly works now, but the go list error about the overlay seems to come back as a diagnostic. We shouldn't show that error.

@stamblerre stamblerre added this to the gopls/v0.3.0 milestone Jan 24, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jan 26, 2020

Change https://golang.org/cl/216310 mentions this issue: internal/lsp: don't show list errors unless necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.