Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: incorrect active parameter for signature help #36766

Closed
stamblerre opened this issue Jan 25, 2020 · 2 comments
Closed

x/tools/gopls: incorrect active parameter for signature help #36766

stamblerre opened this issue Jan 25, 2020 · 2 comments
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jan 25, 2020

Borrowing the repro from saibing/bingo#20:

package main

func foo(a, b int) int {
	return 42
}

func main() {
	foo(<>
}

Looks like we return b as the active parameter instead of a when signature help is triggered at the marked position.

@oblitum
Copy link

@oblitum oblitum commented Jan 25, 2020

Notice that the issue does not happen when the parentheses pair is expanded by snippet. To trigger the problem it's needed to type opening parentheses. It happens when it's left open and there isn't a closing one.

@gopherbot
Copy link

@gopherbot gopherbot commented Jan 26, 2020

Change https://golang.org/cl/216309 mentions this issue: internal/lsp: fix active parameter for incomplete parentheses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.