Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: Document that DNSError.IsNotFound has been added in 1.13 #36767

Closed
rillig opened this issue Jan 25, 2020 · 0 comments
Closed

net: Document that DNSError.IsNotFound has been added in 1.13 #36767

rillig opened this issue Jan 25, 2020 · 0 comments
Labels

Comments

@rillig
Copy link
Contributor

@rillig rillig commented Jan 25, 2020

What version of Go are you using?

1.13 for developing
1.12 for building and shipping

What did you do?

In my code I accessed "net".DNSError.IsNotFound.
The documentation of that fields says nothing version-specific, therefore I assumed that this flag had always been there.
It has been added in #28635 and is only available since 1.13.
Therefore the documentation should include the usual "; added in Go 1.13".

@rillig rillig changed the title Document that DNSError.IsNotFound has been added in 1.13 net: Document that DNSError.IsNotFound has been added in 1.13 Jan 25, 2020
@rillig rillig closed this Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.