Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/acme/autocert: add hooks for transaction locks #36818

Open
rgooch opened this issue Jan 27, 2020 · 0 comments
Open

x/crypto/acme/autocert: add hooks for transaction locks #36818

rgooch opened this issue Jan 27, 2020 · 0 comments

Comments

@rgooch
Copy link

@rgooch rgooch commented Jan 27, 2020

The Manager.createCert method has a lock around the ACME transaction so that multiple goroutines can safely call this method concurrently. This does not protect against multiple processes (possibly on different machines) doing this concurrently.

If transaction hooks were added, then a caller could provide a custom Cache which uses remote storage, allowing multiple servers to safely request certificate generation/renewal and share the certificates.

If this approach is acceptable, I can start work on a PR.

@gopherbot gopherbot added this to the Unreleased milestone Jan 27, 2020
@ALTree ALTree changed the title x/crypto/acme/autocert: Add hooks for transaction locks x/crypto/acme/autocert: add hooks for transaction locks Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants