Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/talks: 2 sets of deploy instructions #36825
I've recently realized that, due to a series of unfortunate events spanning 2014-2020, we have accidentally ended up with 2 sets of deploy instructions for talks.golang.org:
We should pick one as canonical (likely the one in
Making this issue quickly so I don't forget; will add more history/background later.
I investigated whether the deploy instructions in x/build/cmd/tip (which have the auto-deploy feature) can still be used today, but they have atrophied and cannot be used without making changes to get them functional again. I tried making small and safe changes to get them working, but it turned out larger changes are required to get them functional without also breaking tip.golang.org in the process. (I've described how they're broken in a separate issue #38120.)
The deploy instructions in x/talks are functional and have been used most recently. They lack the auto-deploy feature, unfortunately.
We could resolve this issue by continuing to use deploy instructions in golang.org/x/talks README for now, delete the non-functional instructions in x/build/cmd/tip (or at least mark them as "broken" and in need of fixing), and file a tracking issue about restoring the auto-deploy of x/talks content feature that used to exist. It can be resolved by making x/build/cmd/tip functional for serving talks.golang.org again, or another way.
Alternatively, we can fix x/cmd/tip deploy instructions (i.e., resolve #38120) and use them. I'll investigate that issue some more first.