Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509, x/crypto/cryptobyte: panic in certificate parsing #36837

Closed
katiehockman opened this issue Jan 28, 2020 · 1 comment
Closed

crypto/x509, x/crypto/cryptobyte: panic in certificate parsing #36837

katiehockman opened this issue Jan 28, 2020 · 1 comment
Labels
Milestone

Comments

@katiehockman
Copy link
Member

@katiehockman katiehockman commented Jan 28, 2020

On 32-bit architectures, a malformed input to crypto/x509 or the ASN.1 parsing functions of golang.org/x/crypto/cryptobyte can lead to a panic.

The malformed certificate can be delivered via a crypto/tls connection to a client, or to a server that accepts client certificates. net/http clients can be made to crash by an HTTPS server, while net/http servers that accept client certificates will recover the panic and are unaffected.

Thanks to Project Wycheproof for providing the test cases that led to the discovery of this issue.

The issue is CVE-2020-7919.

This is also fixed in version v0.0.0-20200124225646-8b5121be2f68 of golang.org/x/crypto/cryptobyte.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jan 28, 2020

The crypto/x509 part is fixed in master (which will become Go 1.14) in commit b13ce14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.