Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tour: bug/feedback reporter links to the wrong issue tracker #36843

Closed
cagedmantis opened this issue Jan 28, 2020 · 4 comments
Closed

x/tour: bug/feedback reporter links to the wrong issue tracker #36843

cagedmantis opened this issue Jan 28, 2020 · 4 comments
Labels
Documentation FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@cagedmantis
Copy link
Contributor

The feedback reporter on the top of each tour page links to the creation of an issue in the golang/tour issue tracker instead of the golang/go issue tracker. The documentation in the golang/tour repository directs the users to create an issue in the golang/go issue tracker.

@gopherbot gopherbot added this to the Unreleased milestone Jan 28, 2020
@ALTree
Copy link
Member

ALTree commented Jan 28, 2020

But we have always used the golang/tour issue tracker for the tour issues. It's the README that is wrong IMO.

(unless you are planning to change this policy)

@cagedmantis
Copy link
Contributor Author

@ALTree The link and the README should align. Let's ask the greater @golang/osp-team.

@dmitshur
Copy link
Contributor

dmitshur commented Jan 29, 2020

I believe the intention is for issues related to the content of the tour to be reported in the golang/tour issue tracker. The feedback reporter on the top of each tour page links to the right place.

Issues related to the code in the golang.org/x/tour repository should be in the main Go issue tracker with a prefix of "tour:".

I think the README in x/tour repository can be made more clear.

We should also change it to suggest a prefix "x/tour:" rather than "tour:". That would be more consistent with other golang.org/x Go packages, e.g., "x/net", "x/tools", etc.

@dmitshur dmitshur added Documentation help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Jan 29, 2020
@gopherbot
Copy link

Change https://golang.org/cl/217357 mentions this issue: README: clarify where tour issues should be reported

@golang golang locked and limited conversation to collaborators Jan 31, 2021
gopherbot pushed a commit to golang/website that referenced this issue May 26, 2021
Issues with the tour code should be reported in the tracker at

  github.com/golang/go/issues

While the 'report bug' button in the tour itself points to the
issue tracker at

  github.com/golang/tour/issues

which is the one where issues about the tour's content should
be reported. Make this clear in the README.

Fixes golang/go#36843

Change-Id: I7844ea1a15470fdfbc970a9485d37250a6c38779
Reviewed-on: https://go-review.googlesource.com/c/tour/+/217357
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
X-Tour-Commit: 8f38c9a8d074c1943ede6463d78b0d769331dd3e
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
Issues with the tour code should be reported in the tracker at

  github.com/golang/go/issues

While the 'report bug' button in the tour itself points to the
issue tracker at

  github.com/golang/tour/issues

which is the one where issues about the tour's content should
be reported. Make this clear in the README.

Fixes golang/go#36843

Change-Id: I7844ea1a15470fdfbc970a9485d37250a6c38779
Reviewed-on: https://go-review.googlesource.com/c/tour/+/217357
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
X-Tour-Commit: 8f38c9a8d074c1943ede6463d78b0d769331dd3e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

4 participants