Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: detect pseudoversions in `gopls version` #36847

Closed
stamblerre opened this issue Jan 28, 2020 · 3 comments
Closed

x/tools/gopls: detect pseudoversions in `gopls version` #36847

stamblerre opened this issue Jan 28, 2020 · 3 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jan 28, 2020

We originally started tagging releases on master, which means that gopls@master reports its version as a pseudoversion starting with v0.1.8 (the last tag on master). This is misleading for users, at it makes its seem that master is behind latest. We should instead detect the pseudoversion and output something else when the user is at master.

@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Jan 28, 2020
@bcmills
Copy link
Member

@bcmills bcmills commented Jan 28, 2020

Better still, add some pre-release tags on the master branch.

(For example, you could tag the first commit after gopls-release-branch.0.2 was cut as gopls/v0.3.0-dev so that all of the pseudo-versions from that point sort as pre-releases for v0.3.0.)

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Jan 29, 2020

We've come to the realization that we probably won't be principled about tagging pre-release tags on master, and with that approach, the automatic version detection in VS Code version won't work for users that opt-into pre-releases. As an alternative, we're considering deleting all of the tags on master so that the pseudoversion appears as v0.0.0. This will have the effect of invalidating those pre-existing pseudoversions, which we've concluded is fine since they are old anyway and no one should depend on the gopls module.

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented May 21, 2020

We have since deleted all of the tags that were created on the master branch. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.