Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add check to trybot to catch src/go.mod and src/vendor divergence #36852

Open
dmitshur opened this issue Jan 28, 2020 · 4 comments
Open

x/build: add check to trybot to catch src/go.mod and src/vendor divergence #36852

dmitshur opened this issue Jan 28, 2020 · 4 comments

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jan 28, 2020

We should make it so that trybots catch and report when the src/go.mod and src/vendor directories are not in sync, to prevent them from going out of sync without anyone noticing.

See #36851 for more context.

/cc @golang/osp-team

@dmitshur

This comment has been minimized.

Copy link
Member Author

@dmitshur dmitshur commented Feb 21, 2020

@bcmills I think this issue is the same as issue #36907 (which was created slightly later), and can be considered resolved via CL 217218. Do you agree?

@dmitshur

This comment has been minimized.

Copy link
Member Author

@dmitshur dmitshur commented Feb 21, 2020

Oh, I misread, this is about divergence between go.mod and vendor. That issue was about divergence between two different go.mods.

@dmitshur

This comment has been minimized.

Copy link
Member Author

@dmitshur dmitshur commented Feb 21, 2020

That said, the test in CL 217218 seems to check for this issue too, does it not?

Edit: It only checks for missing vendored packages, not that the vendored packages are identical.

@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Feb 24, 2020

Correct. The new test only checks that vendor/modules.txt is consistent with go.mod: it does not verify that the actual vendored source code is unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.