Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: retry workspace initialization as needed #36854

Closed
stamblerre opened this issue Jan 28, 2020 · 1 comment
Closed

x/tools/gopls: retry workspace initialization as needed #36854

stamblerre opened this issue Jan 28, 2020 · 1 comment

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jan 28, 2020

We currently try loading a user's workspace with ./... on gopls start, and if that fails, we mark it as an error and don't try again. We are able to reclaim some workspace packages, but we don't retry the full workspace load. We should determine a strategy for handling this.

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Jul 30, 2020

We currently retry the initial workspace load if the go.mod file changes. This seems like a good starting point, and we can consider other cases as issues are reported. This is too general of an issue to be useful any longer, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.