Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto: commits lost from 1.13 release branch #36866

Closed
rittneje opened this issue Jan 29, 2020 · 1 comment
Closed

x/crypto: commits lost from 1.13 release branch #36866

rittneje opened this issue Jan 29, 2020 · 1 comment
Milestone

Comments

@rittneje
Copy link

@rittneje rittneje commented Jan 29, 2020

We have a mirror job for the x/crypto repo. It is now failing because commit 8b5121be2f68d8fc40bb06467003bdde1040a094 was applied on top of commit 5c40567. So the following commits have vanished from the head of release-branch.go1.13:

Was this expected?

@gopherbot gopherbot added this to the Unreleased milestone Jan 29, 2020
@ALTree
Copy link
Member

@ALTree ALTree commented Jan 29, 2020

See #36842 (comment):

The release branches in x/crypto are really internal implementation details, they are not documented and not covered by our security policies, and I didn't know anyone actually used them.

I'm closing here as a dup, but feel free to subscribe to that other thread. I'm afraid the conclusion is "do not track those branches, only master is supposed to be tracked".

@ALTree ALTree closed this Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.