Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: data race in #36872

bcmills opened this issue Jan 29, 2020 · 1 comment


Copy link

@bcmills bcmills commented Jan 29, 2020

There appears to be a highly reproducible data race in

I'm not sure when it was introduced, but it has been present since at least January 17. It reproduces on the master Go branch, so seems to be distinct from #36687 / #36605, but the regression may have gone unnoticed because folks assumed the failure was due to that known issue.

Write at 0x00c0001ce168 by goroutine 3336:
      /tmp/workdir/gopath/src/ +0x598
      /tmp/workdir/gopath/src/ +0x9e
      /tmp/workdir/gopath/src/ +0x72*connection).initialize()
      /tmp/workdir/gopath/src/ +0x47d*Application).connect()
      /tmp/workdir/gopath/src/ +0xfd6*check).Run()
      /tmp/workdir/gopath/src/ +0xf5
      /tmp/workdir/gopath/src/ +0x304*Application).Run()
      /tmp/workdir/gopath/src/ +0x3f5
      /tmp/workdir/gopath/src/ +0x304*runner).RunGoplsCmd()
      /tmp/workdir/gopath/src/ +0x611*runner).Diagnostics()
      /tmp/workdir/gopath/src/ +0x1d0
      /tmp/workdir/gopath/src/ +0xff
      /tmp/workdir/go/src/testing/testing.go:909 +0x199

Previous read at 0x00c0001ce168 by goroutine 911:
      /tmp/workdir/gopath/src/ +0x174
      /tmp/workdir/gopath/src/ +0x739*Server).diagnose.func1.1()
      /tmp/workdir/gopath/src/ +0x1cb

Goroutine 3336 (running) created at:
      /tmp/workdir/go/src/testing/testing.go:960 +0x651
      /tmp/workdir/gopath/src/ +0x150
      /tmp/workdir/go/src/testing/testing.go:909 +0x199

Goroutine 911 (finished) created at:*Server).diagnose.func1()
      /tmp/workdir/gopath/src/ +0x180

Copy link
Member Author

@bcmills bcmills commented Jan 29, 2020

Duplicate of #36699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.