Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: references fails with 'no identifier found' #36917

Closed
stamblerre opened this issue Jan 31, 2020 · 4 comments
Closed

x/tools/gopls: references fails with 'no identifier found' #36917

stamblerre opened this issue Jan 31, 2020 · 4 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jan 31, 2020

Filing this now so I don't forget, but the repro case won't be great. I was working in golang.org/x/tools/internal/lsp/cache package in golang.org/x/tools/internal/lsp/cache/snapshot.go. I did find references on a field of snapshot, specifically on s.ids. It works fine if you run find references from the definition of the field, but it failed when I called it on a use of the field.

/cc @muirdm

@muirdm
Copy link

@muirdm muirdm commented Jan 31, 2020

On first attempt I can't reproduce anything like that. no identifier found means we didn't find an *ast.Ident at the requested position. Maybe you had a syntax error that was messing up the AST, or maybe content was out of sync somehow? Can you reproduce it?

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Jan 31, 2020

Ah yes - just realized what it was! It was a map lookup - s.ids[uri]. I am able to consistently reproduce it.

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Jan 31, 2020

The issue seems to exist only on master, not on gopls/v0.3.0-pre3.

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Jan 31, 2020

I'm so sorry for the bother - it was my own CL that's causing it. I'll investigate why it's happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.