Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: relative links in blog.golang.org posts 404s when followed from the golang.org homepage #36930

Closed
s-chand opened this issue Jan 31, 2020 · 3 comments
Assignees
Labels
Milestone

Comments

@s-chand
Copy link

@s-chand s-chand commented Jan 31, 2020

What version of Go are you using (go version)?

$ go version

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

What did you do?

I visited the Golang.org web page and got a link to an error page which was referenced as though it was available.

I have attached images

What did you expect to see?

The reference to Go 2 Here we come to work or atleast not to display an error

What did you see instead?

I got an lstat error message
Screenshot 2020-01-31 at 16 41 36
Screenshot 2020-01-31 at 16 41 51

@gopherbot gopherbot added this to the Unreleased milestone Jan 31, 2020
@ALTree
Copy link
Member

@ALTree ALTree commented Jan 31, 2020

Thanks for reporting this.

If you click on that link from the homepage, it goes to golang.org/go2-here-we-come, which 404s, while if you open the blog post (https://blog.golang.org/go1.15-proposals) and then click on the link, it goes to blog.golang.org/go2-here-we-come, which is correct.

cc @toothrot @cagedmantis @dmitshur

@ALTree ALTree changed the title x/website: https://golang.org/ x/website: relative links in blog.golang.org posts 404s when followed from the golang.org homepage Jan 31, 2020
@dmitshur dmitshur self-assigned this Jan 31, 2020
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jan 31, 2020

Thanks for the report. When making a code review suggestion in CL 216199, I didn't take it into account that blog posts are embedded directly on golang.org, and thus cannot use relative relative links to other blog.golang.org pages.

I'll send a fix by rolling back CL 216626 which implemented my faulty suggestion, and file an issue about catching this potential problem via a test. Edit: Filed #36944.

@gopherbot
Copy link

@gopherbot gopherbot commented Jan 31, 2020

Change https://golang.org/cl/217239 mentions this issue: content/go1.15-proposals.article: revert "use relative links for other blog articles"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.