Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: support searching for internal packages #36940

Open
stamblerre opened this issue Jan 31, 2020 · 2 comments
Open

x/pkgsite: support searching for internal packages #36940

stamblerre opened this issue Jan 31, 2020 · 2 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jan 31, 2020

@stamblerre stamblerre added the pkgsite label Jan 31, 2020
@myitcv
Copy link
Member

@myitcv myitcv commented Jan 31, 2020

Probably related to #36803 #36804 and #36806

@gopherbot gopherbot added this to the Unreleased milestone Feb 6, 2020
@neild
Copy link
Contributor

@neild neild commented Feb 17, 2020

As a related issue, but in the other direction: If I look at https://pkg.go.dev/google.golang.org/protobuf/, I see both internal and external packages in the module packages list. I don't think the internal ones should be there by default, or should be in a separate section after the external ones. They distract from the public interface of the module.

@julieqiu julieqiu changed the title go.dev: support searching for internal packages x/pkgsite: support searching for internal packages Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.