Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: support searching for internal packages #36940

Open
stamblerre opened this issue Jan 31, 2020 · 2 comments
Open

x/pkgsite: support searching for internal packages #36940

stamblerre opened this issue Jan 31, 2020 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/search Issues related to pkg.go.dev search functionality pkgsite

Comments

@stamblerre
Copy link
Contributor

stamblerre commented Jan 31, 2020

For example: https://pkg.go.dev/search?q=internal%2Flsp should return results including https://pkg.go.dev/golang.org/x/tools/internal/lsp?tab=doc.

@myitcv
Copy link
Member

myitcv commented Jan 31, 2020

Probably related to #36803 #36804 and #36806

@julieqiu julieqiu added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 31, 2020
@gopherbot gopherbot added this to the Unreleased milestone Feb 6, 2020
@neild
Copy link
Contributor

neild commented Feb 17, 2020

As a related issue, but in the other direction: If I look at https://pkg.go.dev/google.golang.org/protobuf/, I see both internal and external packages in the module packages list. I don't think the internal ones should be there by default, or should be in a separate section after the external ones. They distract from the public interface of the module.

@julieqiu julieqiu changed the title go.dev: support searching for internal packages x/pkgsite: support searching for internal packages Jun 15, 2020
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/search Aug 19, 2020
@julieqiu julieqiu removed the website label Sep 22, 2020
@julieqiu julieqiu removed the website label Jun 10, 2021
@hyangah hyangah added the pkgsite/search Issues related to pkg.go.dev search functionality label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/search Issues related to pkg.go.dev search functionality pkgsite
Projects
None yet
Development

No branches or pull requests

6 participants