Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: VS Code breadcrumbs broken with methods #36949

Open
stamblerre opened this issue Jan 31, 2020 · 1 comment
Open

x/tools/gopls: VS Code breadcrumbs broken with methods #36949

stamblerre opened this issue Jan 31, 2020 · 1 comment

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jan 31, 2020

@stamblerre

This comment has been minimized.

Copy link
Contributor Author

@stamblerre stamblerre commented Feb 2, 2020

After some quick investigation, it seems that this is caused by our use of the hierarchical symbol support to categorized methods below their receiver's type. The behavior of the VS Code extension is to show something like (*a).b at the top level, instead of a, which has a child symbol b(). I think that VS Code's breadcrumbs break because the child symbol's position is not contained within the range of the parent symbol. Based on that behavior, I think that we can fix this by treating methods as top-level symbols.

@stamblerre stamblerre added the NeedsFix label Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.