Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: add support for dark mode #36980

Open
A-UNDERSCORE-D opened this issue Feb 2, 2020 · 2 comments
Open

x/pkgsite: add support for dark mode #36980

A-UNDERSCORE-D opened this issue Feb 2, 2020 · 2 comments

Comments

@A-UNDERSCORE-D
Copy link

@A-UNDERSCORE-D A-UNDERSCORE-D commented Feb 2, 2020

What is the URL of the page with the issue?

All Pages (noticed explicitly on my first use, which was os.ProcessState.Success)

What is your user agent?

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:72.0) Gecko/20100101 Firefox/72.0

What did you expect to see?

Support for my already configured system wide dark mode (via CSS prefers-colour-scheme)

Or at the very least a toggle button somewhere to enable something less eye-searing for those of us working at night or in the dark

What did you see instead?

I didnt. I was blinded.

But in all seriousness, a beautifully designed, if bright white docs page. Which instantly clashed with the rest of my system as it is configured to have a dark GTK theme, et al.

On the old godoc.org, I managed this though a stylus theme, but I'd much rather have first party support on pkg.go.dev.

@ALTree ALTree added the pkgsite label Feb 3, 2020
@julieqiu julieqiu changed the title go.dev: Dark Mode/Theme go.dev: add support for dark mode Feb 3, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Feb 3, 2020

@cagedmantis cagedmantis added this to the Backlog milestone Feb 3, 2020
@toothrot toothrot modified the milestones: Backlog, Unreleased Feb 6, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Feb 28, 2020

We're currently discussing this request with our UX team, along with other design feedback we've received for the site. We want to review design feedback we have received as part of a broader redesign, as opposed to make piecemeal decisions. I'll update this issue once we have decided on any changes.

/cc @fflewddur

@julieqiu julieqiu added OS-Linux UX and removed OS-Linux labels Feb 28, 2020
@julieqiu julieqiu changed the title go.dev: add support for dark mode x/pkgsite: add support for dark mode Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.