Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: respect GOPRIVATE setting for links to documentation on hover #36998

Open
stamblerre opened this issue Feb 3, 2020 · 1 comment
Open

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Feb 3, 2020

Reported on Slack. We shouldn't over links to packages covered by GOPRIVATE.

@hyangah

This comment has been minimized.

Copy link
Contributor

@hyangah hyangah commented Feb 3, 2020

Just want mention a different use case: organizations that run their internal doc servers would want the linkTarget to point to their doc servers. OTOH, I expect they can easily set up private proxies to avoid depending on GOPRIVATE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.