Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/exp/apidiff: report change in package name #37003

Open
jayconrod opened this issue Feb 3, 2020 · 0 comments
Open

x/exp/apidiff: report change in package name #37003

jayconrod opened this issue Feb 3, 2020 · 0 comments
Labels
NeedsFix
Milestone

Comments

@jayconrod
Copy link
Contributor

@jayconrod jayconrod commented Feb 3, 2020

What did you do?

Compare two packages which are identical except for package name.

What did you expect to see?

apidiff should report a change if the package name is different. I'd argue that this is always an incompatible change.

An interesting question is whether changing a main package to something else is compatible. From the perspective of importing packages, it's a compatible change, since main couldn't be imported before. However, anything that depends on a main package being built as a binary will break.

What did you see instead?

No difference reported.

cc @bcmills @jba @matloob

@jayconrod jayconrod added the NeedsFix label Feb 3, 2020
@jayconrod jayconrod added this to the Unreleased milestone Feb 3, 2020
@jba jba self-assigned this Feb 5, 2020
@rsc rsc unassigned jba Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix
Projects
None yet
Development

No branches or pull requests

2 participants