Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: misc-compile-other failed building linux-riscv64 on master #37022

Closed
dmitshur opened this issue Feb 4, 2020 · 9 comments
Closed

x/build: misc-compile-other failed building linux-riscv64 on master #37022

dmitshur opened this issue Feb 4, 2020 · 9 comments

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Feb 4, 2020

The misc-compile-other trybot failed on a revert CL in https://go-review.googlesource.com/c/go/+/217721/1#message-9811efced365690ee611f620906e7ecf9b175a15:

### Building linux-riscv64
# internal/bytealg
internal/bytealg/indexbyte_riscv64.s:9:1: [riscv64] IndexByte: unknown variable s; offset 0 is b_base+0(FP)
internal/bytealg/indexbyte_riscv64.s:10:1: [riscv64] IndexByte: unknown variable s_len; offset 8 is b_len+8(FP)
internal/bytealg/indexbyte_riscv64.s:32:1: [riscv64] IndexByteString: unknown variable p; offset 0 is s_base+0(FP)
internal/bytealg/indexbyte_riscv64.s:33:1: [riscv64] IndexByteString: unknown variable b_len; offset 8 is s_len+8(FP)

(Source: https://storage.googleapis.com/go-build-log/bd45c843/misc-compile-other_598ce4f1.log.)

Need to investigate why this happened and where the fix belongs.

/cc @4a6f656c @golang/osp-team

@bcmills
Copy link
Member

@bcmills bcmills commented Feb 4, 2020

I think we should roll back CL 216758 and turn off the TryBot for 1.14. A port without a passing builder is not “complete”, and the 1.14 release is not supposed to be gated on the RISC-V development work that went in during the freeze.

@dmitshur
Copy link
Member Author

@dmitshur dmitshur commented Feb 4, 2020

This started to happen now because coordinator was redeployed yesterday (see #36802 (comment)), and it picked up the change in x/build/dashboard:

addMiscCompile("-other", "^(windows-arm|linux-s390x|linux-riscv64|dragonfly-amd64)$")

@toothrot is sending a CL to remove linux-riscv64 from misc-compile-other trybot now.

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 4, 2020

Change https://golang.org/cl/217723 mentions this issue: Revert "cmd/buildlet: add riscv64 buildlet"

gopherbot pushed a commit to golang/build that referenced this issue Feb 4, 2020
This reverts CL 216765 (git 992a312)

Reason for revert: This trybot is broken.

Updates golang/go#37022

Change-Id: I8ff1e53e3edba7c461d1f46701df02b844b1f3a1
Reviewed-on: https://go-review.googlesource.com/c/build/+/217723
Run-TryBot: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 4, 2020

Change https://golang.org/cl/217739 mentions this issue: test trybots after CL 217723

@dmitshur
Copy link
Member Author

@dmitshur dmitshur commented Feb 4, 2020

I tested that trybots are passing on master branch by sending an empty CL 217739, and they are:

TryBots are happy.

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 4, 2020

Change https://golang.org/cl/217777 mentions this issue: internal/bytealg: fix riscv64 offset names

gopherbot pushed a commit that referenced this issue Feb 4, 2020
Vet caught that these were incorrect.

Updates #37022

Change-Id: I7b5cd8032ea95eb8e0729f6a4f386aec613c71d8
Reviewed-on: https://go-review.googlesource.com/c/go/+/217777
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@4a6f656c
Copy link
Contributor

@4a6f656c 4a6f656c commented Feb 6, 2020

FTR the failure should be addressed by https://golang.org/cl/217777, which fixed the offset names in internal/bytealg.

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 20, 2020

Change https://golang.org/cl/224580 mentions this issue: cmd/buildlet: re-add riscv64 buildlet and misc-compile trybot

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 23, 2020

Change https://golang.org/cl/224901 mentions this issue: test misc-compile-other after CL 224580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.