Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: store overlays on the snapshot instead of the session #37027

Closed
stamblerre opened this issue Feb 4, 2020 · 1 comment
Closed

x/tools/gopls: store overlays on the snapshot instead of the session #37027

stamblerre opened this issue Feb 4, 2020 · 1 comment
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Feb 4, 2020

@findleyr discovered a bug where if a textDocument/didOpen opens an overlay that does not exist on disk before the initial workspace load runs, we will attempt to read a file that does not exist on disk.

Snapshots should store their overlays so that we don't attempt to read data that came in after the snapshot was created.

@stamblerre stamblerre added this to the gopls/v0.4.0 milestone Feb 4, 2020
@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Feb 7, 2020

@stamblerre stamblerre closed this Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.