Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build: investigate why vet failures on tip weren't caught by builders #37053
This turned out to be an undetected regression in the behavior of
When we turned down
And that's why it wasn't caught: we were testing a (slightly) different property from the one we actually wanted to hold. The testing verified that “all
We didn't have a regression test for that last part, so when it regressed we also didn't detect the regression in the desired property that it implies.