Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: document that SetCookie can quote the value #37055

Open
gazerro opened this issue Feb 5, 2020 · 1 comment
Open

net/http: document that SetCookie can quote the value #37055

gazerro opened this issue Feb 5, 2020 · 1 comment

Comments

@gazerro
Copy link

@gazerro gazerro commented Feb 5, 2020

The SetCookie function quotes the value if it contains spaces or commas but this behavior is not documented in SetCookie documentation:

SetCookie adds a Set-Cookie header to the provided ResponseWriter's headers. The provided cookie must have a valid Name. Invalid cookies may be silently dropped.

@odeke-em

This comment has been minimized.

Copy link
Member

@odeke-em odeke-em commented Feb 5, 2020

Thank you for the report @gazerro! Kindly cc-ing @vdobler for Cookies.

@cagedmantis cagedmantis added this to the Backlog milestone Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.