Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/imports: self-import offered for standard library #37063

Closed
stamblerre opened this issue Feb 5, 2020 · 1 comment
Closed

x/tools/internal/imports: self-import offered for standard library #37063

stamblerre opened this issue Feb 5, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Feb 5, 2020

Repro:

Open crypto/ecdsa/ecdsa.go and paste https://github.com/golang/crypto/blob/c9f3fb736b729628ec1e9c1a6b4313e883f452f9/internal/wycheproof/internal/ecdsa/ecdsa.go#L19b into bottom. The import will be added, creating a circular import.

Reported by @katiehockman.

@stamblerre stamblerre added this to the gopls/v0.4.0 milestone Feb 5, 2020
@gopherbot gopherbot added the Tools label Feb 5, 2020
@heschik heschik self-assigned this Feb 5, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 5, 2020

Change https://golang.org/cl/217958 mentions this issue: internal/imports: prevent self-imports in the stdlib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.