Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509: MarshalPKCS8PrivateKey doc says RSA private key while it supports more than that [1.14 backport] #37068

Closed
gopherbot opened this issue Feb 5, 2020 · 3 comments
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 5, 2020

@katiehockman requested issue #36735 to be considered for backport to the next 1.14 minor release.

@gopherbot please backport to 1.13 and 1.14

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Feb 5, 2020

Change https://golang.org/cl/217999 mentions this issue: [release-branch.go1.14] crypto/x509: fix godoc for MarshalPKCS8PrivateKey

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Feb 5, 2020

Closed by merging 3f0cded to release-branch.go1.14.

@gopherbot gopherbot closed this Feb 5, 2020
gopherbot pushed a commit that referenced this issue Feb 5, 2020
…eKey

Updates #36735
Fixes #37068

Change-Id: I93f005d78f4bfac773272995b165172461bae92f
Reviewed-on: https://go-review.googlesource.com/c/go/+/217917
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
(cherry picked from commit 7a36fa4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/217999
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Feb 7, 2020

This change does not need to go through backport process because we're still in code freeze for 1.14, so all changes to master are expected to be included in subsequent release candidates (if any) and the final 1.14 release. Even if this commit wasn't explicitly cherry-picked to release-branch.go1.14, it would've been included via a merge commit such as CL 218318.

I'll update the CherryPickCandidate label to CherryPickApproved to reflect the reality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.