Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: improve completion in binary expressions #37163

Open
muirdm opened this issue Feb 11, 2020 · 1 comment
Open

x/tools/gopls: improve completion in binary expressions #37163

muirdm opened this issue Feb 11, 2020 · 1 comment
Labels
Milestone

Comments

@muirdm
Copy link

@muirdm muirdm commented Feb 11, 2020

When completing in situations like:

if foo == bar || baz<> {
}

We detect the expected type as "bool" since that is the type of "foo == bar". That causes "bool" candidates to dominate the rankings. However, if your intention is to type "baz.blub == 123", bool candidates are counterproductive, and often obscure the candidate you want.

I propose we get rid of the binary operator type inference for || and && so all candidates are easily completable.

/cc @stamblerre

@gopherbot gopherbot added this to the Unreleased milestone Feb 11, 2020
@gopherbot gopherbot added the Tools label Feb 11, 2020
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Feb 11, 2020

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@gopherbot gopherbot added the gopls label Feb 11, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v1.0.0 Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.