Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: improve completion in binary expressions #37163

muirdm opened this issue Feb 11, 2020 · 1 comment

x/tools/gopls: improve completion in binary expressions #37163

muirdm opened this issue Feb 11, 2020 · 1 comment


Copy link

@muirdm muirdm commented Feb 11, 2020

When completing in situations like:

if foo == bar || baz<> {

We detect the expected type as "bool" since that is the type of "foo == bar". That causes "bool" candidates to dominate the rankings. However, if your intention is to type "baz.blub == 123", bool candidates are counterproductive, and often obscure the candidate you want.

I propose we get rid of the binary operator type inference for || and && so all candidates are easily completable.

/cc @stamblerre

@gopherbot gopherbot added this to the Unreleased milestone Feb 11, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v1.0.0 Feb 13, 2020
@stamblerre stamblerre removed this from the gopls/v0.5.0 milestone Jun 20, 2020
@golang golang deleted a comment from gopherbot Jul 23, 2020
Copy link

@gopherbot gopherbot commented Aug 2, 2020

Change mentions this issue: internal/lsp/source: don't prefer bool candidates in bool exprs

@stamblerre stamblerre added this to the gopls/v.0.4.5 milestone Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants