Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/tools/gopls: Load concurrency error reported to LSP client #37164
What version of Go are you using (
My understanding of an error being logged from server to client is that the client/user should do something with that error, i.e. investigate/report it. Hence why I'm pushing to try and eliminate all errors that are not actually errors, as well as having generic assertions in tests that verify we haven't seen any errors in the course of normal behaviour. However, if this understanding is wrong, please correct me!
If it can, then I don't think this should be reported as an error.
If it can't, what are we expecting the client/user to do with the error?
cc @findleyr given discussions about
I'm not sure that I agree. To me, there is a distinction between a logged message (
I'm going to go ahead and close this issue. Please re-open if you have further thoughts, but I don't think it's incorrect for us to log the error here.
What I would expect, and I could be totally wrong, is that a log message that tells me:
Is, at most, a warning. As opposite to:
That is an error.
I'm not saying that we should re-open the issue, just wanted to share my thoughts.