net/rpc/jsonrpc: fails to ignore invalid object parameters

[gopherbot]

by ThoughtMonster:

Given a simple JSON-RPC server in http://play.golang.org/p/S9vSE6lVFR, requests fail
with "rpc: JSON decoder out of sync - data changing underfoot?" when given a
JSON-RPC request like the following:

{"jsonrpc":"2.0","method":"Server.Echo","params":["article",{"category":1}],"id":"1"}

To reproduce, connect to the server via telnet and echo the above string.

In this case, it seems that jsonrpc is not ignoring the additional object parameter,
which leads to the above issue.

GDB tells me that the error is reached in decode.go:383.

Using go version 1.0.1, on ArchLinux x86-64, using the 6g compiler.

[rsc]

Comment 1:

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

[rsc]

Comment 2:

Labels changed: added go1.1.

[rsc]

Comment 3:

Labels changed: added size-m.

[rsc]

Comment 4:

Labels changed: added suggested.

[gopherbot]

Comment 5 by rickarnoldjr:

https://golang.org/cl/7490046/

[gopherbot]

Comment 6 by robryk:

A reduced test case is in http://play.golang.org/p/OYCGWFzZGp
The problem seems to appear only when the last element in a JSON array is an object, and
is ignored.

[rsc]

Comment 7:

This issue was closed by revision cb8aebf.

Status changed to Fixed.