Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: parse additional fields in CertificateRequest #37172

Closed
chauncyc opened this issue Feb 11, 2020 · 7 comments
Closed

crypto/x509: parse additional fields in CertificateRequest #37172

chauncyc opened this issue Feb 11, 2020 · 7 comments
Labels
NeedsFix Proposal-Accepted Proposal-Crypto
Projects
Proposals
Milestone
Go1.16

Comments

@chauncyc
Copy link
Contributor

@chauncyc chauncyc commented Feb 11, 2020

What version of Go are you using (go version)?

$ 1.13.4

ParseCertificate parses many common extensions and puts them in the Certificate struct. I'd like for ParseCertificateRequest to do the same. Specifically, I currently manually parse the following fields from CertificateRequest.Extensions, and would like for them to be added to CertificateRequest, with the corresponding changes to ParseCertificateRequest and CreateCertificateRequest, exactly as they're implemented for Certificate:

  • KeyUsage
  • ExtKeyUsage
  • UnknownExtKeyUsage
  • IsCA
  • MaxPathLen
  • BasicConstraintsValid
  • MaxPathLenZero
  • SubjectKeyId
  • PolicyIdentifier
@gopherbot gopherbot added this to the Proposal milestone Feb 11, 2020
@gopherbot gopherbot added the Proposal label Feb 11, 2020
@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented Feb 11, 2020

Sounds good, we should even be able to share code with the Certificate parser.
@rsc rsc added this to Active in Proposals Feb 12, 2020
@rsc
Copy link
Contributor

@rsc rsc commented Feb 12, 2020

Adding to proposal minutes, seems headed for likely accept.
@rsc rsc mentioned this issue Feb 12, 2020
Open
@rsc
Copy link
Contributor

@rsc rsc commented Mar 4, 2020

Based on the discussion above this seems like a likely accept.
@rsc rsc moved this from Active to Likely Accept in Proposals Mar 4, 2020
@rsc rsc moved this from Likely Accept to Active in Proposals Mar 4, 2020
@rsc rsc moved this from Active to Likely Accept in Proposals Mar 4, 2020
@rsc
Copy link
Contributor

@rsc rsc commented Mar 11, 2020

No change in consensus, so accepted.
@rsc rsc moved this from Likely Accept to Accepted in Proposals Mar 11, 2020
@gopherbot gopherbot added the Proposal label Mar 11, 2020
@FiloSottile FiloSottile changed the title proposal: crypto/x509: parse additional fields in CertificateRequest crypto/x509: parse additional fields in CertificateRequest Mar 11, 2020
@FiloSottile FiloSottile removed the Proposal label Mar 11, 2020
@FiloSottile FiloSottile modified the milestones: Proposal, Go1.15 Mar 11, 2020
@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented May 8, 2020

Did not happen for Go 1.15.
@FiloSottile FiloSottile modified the milestones: Go1.15, Go1.16 May 8, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented May 10, 2020

Change https://golang.org/cl/233163 mentions this issue: crypto/x509: add additional convenience fields to CertificateRequest
@gopherbot gopherbot closed this in 51f4168 Nov 9, 2020
@dmitshur dmitshur mentioned this issue Dec 28, 2020
Open
450 of 481 tasks complete
@AGWA AGWA mentioned this issue Jan 3, 2021
Closed
@gopherbot
Copy link

@gopherbot gopherbot commented Jan 5, 2021

Change https://golang.org/cl/281235 mentions this issue: crypto/x509: rollback new CertificateRequest fields
gopherbot pushed a commit that referenced this issue Jan 6, 2021
@FiloSottile
crypto/x509: rollback new CertificateRequest fields
4787e90 
In general, we don't want to encourage reading them from CSRs, and
applications that really want to can parse the Extensions field.

Note that this also fixes a bug where the error of
parseKeyUsageExtension was not handled in parseCertificateRequest.

Fixes #43477
Updates #37172

Change-Id: Ia5707b0e23cecc0aed57e419a1ca25e26eea6bbe
Reviewed-on: https://go-review.googlesource.com/c/go/+/281235
Trust: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix Proposal-Accepted Proposal-Crypto
Projects
Proposals
Accepted
Milestone
Go1.16
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@rsc @FiloSottile @gopherbot @chauncyc