Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509: parse additional fields in CertificateRequest #37172

Open
chauncyc opened this issue Feb 11, 2020 · 4 comments
Open

crypto/x509: parse additional fields in CertificateRequest #37172

chauncyc opened this issue Feb 11, 2020 · 4 comments

Comments

@chauncyc
Copy link
Contributor

@chauncyc chauncyc commented Feb 11, 2020

What version of Go are you using (go version)?

$ 1.13.4

ParseCertificate parses many common extensions and puts them in the Certificate struct. I'd like for ParseCertificateRequest to do the same. Specifically, I currently manually parse the following fields from CertificateRequest.Extensions, and would like for them to be added to CertificateRequest, with the corresponding changes to ParseCertificateRequest and CreateCertificateRequest, exactly as they're implemented for Certificate:

  • KeyUsage
  • ExtKeyUsage
  • UnknownExtKeyUsage
  • IsCA
  • MaxPathLen
  • BasicConstraintsValid
  • MaxPathLenZero
  • SubjectKeyId
  • PolicyIdentifier
@gopherbot gopherbot added this to the Proposal milestone Feb 11, 2020
@gopherbot gopherbot added the Proposal label Feb 11, 2020
@FiloSottile

This comment has been minimized.

Copy link
Member

@FiloSottile FiloSottile commented Feb 11, 2020

Sounds good, we should even be able to share code with the Certificate parser.

@rsc rsc added this to Active in Proposals Feb 12, 2020
@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Feb 12, 2020

Adding to proposal minutes, seems headed for likely accept.

@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Mar 4, 2020

Based on the discussion above this seems like a likely accept.

@rsc rsc moved this from Active to Likely Accept in Proposals Mar 4, 2020
@rsc rsc moved this from Likely Accept to Active in Proposals Mar 4, 2020
@rsc rsc moved this from Active to Likely Accept in Proposals Mar 4, 2020
@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Mar 11, 2020

No change in consensus, so accepted.

@rsc rsc moved this from Likely Accept to Accepted in Proposals Mar 11, 2020
@gopherbot gopherbot added the Proposal label Mar 11, 2020
@FiloSottile FiloSottile changed the title proposal: crypto/x509: parse additional fields in CertificateRequest crypto/x509: parse additional fields in CertificateRequest Mar 11, 2020
@FiloSottile FiloSottile removed the Proposal label Mar 11, 2020
@FiloSottile FiloSottile modified the milestones: Proposal, Go1.15 Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Proposals
Accepted
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.