crypto/x509: parse additional fields in CertificateRequest #37172
Comments
Sounds good, we should even be able to share code with the Certificate parser. |
Adding to proposal minutes, seems headed for likely accept. |
Based on the discussion above this seems like a likely accept. |
No change in consensus, so accepted. |
Did not happen for Go 1.15. |
Change https://golang.org/cl/233163 mentions this issue: |
Change https://golang.org/cl/281235 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Jan 6, 2021
In general, we don't want to encourage reading them from CSRs, and applications that really want to can parse the Extensions field. Note that this also fixes a bug where the error of parseKeyUsageExtension was not handled in parseCertificateRequest. Fixes #43477 Updates #37172 Change-Id: Ia5707b0e23cecc0aed57e419a1ca25e26eea6bbe Reviewed-on: https://go-review.googlesource.com/c/go/+/281235 Trust: Filippo Valsorda <filippo@golang.org> Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Roland Shoemaker <roland@golang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of Go are you using (
go version
)?ParseCertificate
parses many common extensions and puts them in theCertificate
struct. I'd like forParseCertificateRequest
to do the same. Specifically, I currently manually parse the following fields fromCertificateRequest.Extensions
, and would like for them to be added toCertificateRequest
, with the corresponding changes toParseCertificateRequest
andCreateCertificateRequest
, exactly as they're implemented forCertificate
:The text was updated successfully, but these errors were encountered: