Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: using fallback hash unconditionally #37212

Closed
randall77 opened this issue Feb 13, 2020 · 1 comment
Closed

runtime: using fallback hash unconditionally #37212

randall77 opened this issue Feb 13, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@randall77
Copy link
Contributor

@randall77 randall77 commented Feb 13, 2020

First reported in #37086 by @SlinSo:

i am not sure if this is related, but i saw some differences in map access performance, too. In my case I am not using interface{} as a key, but instead a map[int]int

https://github.com/SlinSo/random/blob/master/mapaccess_test.go

pprof excerpt:
go1.13.8:
0.73s 9.53% 82.64% 0.73s 9.53% runtime.aeshash64

go1.14rc1:
1230ms 15.81% 66.20% 1410ms 18.12% runtime.memhash64Fallback
140ms 1.80% 97.43% 140ms 1.80% runtime.memhash64

We should not be using the fallback hash unless the processor can't do the AES instructions (which, as evidenced by the 1.13 results, it has).

@randall77 randall77 self-assigned this Feb 13, 2020
@randall77 randall77 added this to the Go1.14 milestone Feb 13, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 13, 2020

Change https://golang.org/cl/219337 mentions this issue: runtime: fix fallback logic for aeshash on 32/64 bit

@gopherbot gopherbot closed this in e237df5 Feb 13, 2020
@dmitshur dmitshur added the NeedsFix label Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.