Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: incorrect active parameter in signature help #37271

Closed
kamilez opened this issue Feb 17, 2020 · 3 comments
Closed

x/tools/gopls: incorrect active parameter in signature help #37271

kamilez opened this issue Feb 17, 2020 · 3 comments

Comments

@kamilez
Copy link

@kamilez kamilez commented Feb 17, 2020

What version of Go are you using (go version)?

gopls version 0.3.0 - 0.3.2
go version go1.13.5 linux/amd64
coc.nvim version: 0.0.74-bc017b02e6

Does this issue reproduce with the latest release?

yes

What did you expect to see?

Properly underlined active function parameter in documentation window on function argument typing.

What did you see instead?

The underline doesn't change even on further parameters typing. The problem appears since commit:
ab09473
(one commit before works perfectly fine)

@gopherbot gopherbot added this to the Unreleased milestone Feb 17, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 17, 2020

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.4.0 Feb 18, 2020
@stamblerre stamblerre changed the title x/tools/gopls: coc nvim active function parameter x/tools/gopls: incorrect active parameter in signature help Feb 18, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Mar 2, 2020

Change https://golang.org/cl/221817 mentions this issue: internal/lsp: fix active param in signature help

@kamilez
Copy link
Author

@kamilez kamilez commented Mar 3, 2020

https://golang.org/cl/221817 fixes the problem (at least in coc.nvim)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.