Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: example code should be displayed as package main when rendering #37291

Open
fishy opened this issue Feb 19, 2020 · 2 comments
Open

x/pkgsite: example code should be displayed as package main when rendering #37291

fishy opened this issue Feb 19, 2020 · 2 comments

Comments

@fishy
Copy link

@fishy fishy commented Feb 19, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/reddit/baseplate.go@v0.0.0-20200327042237-1365288992e4/thriftclient?tab=doc#example-package

What did you expect to see?

On godoc.org, the Example* functions will be renamed to main when rendering, for example: https://godoc.org/github.com/reddit/baseplate.go/thriftclient#example-package

What did you see instead?

On pkg.go.dev we kept the original Example function name in the code.

@gopherbot gopherbot added this to the Unreleased milestone Feb 19, 2020
@gopherbot gopherbot added the pkgsite label Feb 19, 2020
@toothrot
Copy link
Contributor

@toothrot toothrot commented Feb 19, 2020

/cc @julieqiu

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Feb 19, 2020

Thanks for reporting the bug, @fishy! We'll look into it.

/cc @dmitshur

@julieqiu julieqiu changed the title go.dev: Example functions are not renamed to main when rendering go.dev: example code should be displayed as package main when rendering Feb 19, 2020
@julieqiu julieqiu changed the title go.dev: example code should be displayed as package main when rendering x/pkgsite: example code should be displayed as package main when rendering Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.