Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestTLSHandshakeTimeout failure on solaris-amd64-oraclerel builder #37327

Closed
bcmills opened this issue Feb 20, 2020 · 2 comments
Closed

net/http: TestTLSHandshakeTimeout failure on solaris-amd64-oraclerel builder #37327

bcmills opened this issue Feb 20, 2020 · 2 comments
Assignees
@bcmills
Labels
NeedsInvestigation Testing
Milestone
Go1.15

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Feb 20, 2020 

--- FAIL: TestTLSHandshakeTimeout (10.17s)
    serve_test.go:3636: Timeout expired after 10s
FAIL
FAIL	net/http	15.953s

2020-02-19T22:59:15-c4c73ce/solaris-amd64-oraclerel

This looks to me like a too-short hard-coded timeout.

CC @bradfitz
@bcmills bcmills added this to the Backlog milestone Feb 20, 2020
@bcmills bcmills added the Testing label Mar 27, 2020
@bcmills bcmills self-assigned this Mar 27, 2020
@bcmills bcmills modified the milestones: Backlog, Go1.15 Mar 27, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Mar 27, 2020

Change https://golang.org/cl/225977 mentions this issue: net/http: remove arbitrary timeouts from TestIdentityResponse and TestTLSHandshakeTimeout
@gopherbot gopherbot closed this in a5d1a9d Mar 27, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Mar 27, 2020

Change https://golang.org/cl/226137 mentions this issue: net/http: remove another arbitrary timeout in TestTLSHandshakeTimeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcmills bcmills

Labels
NeedsInvestigation Testing
Projects
None yet
Milestone
  Go1.15
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@bcmills @gopherbot
You can’t perform that action at this time.