Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/exp/cmd/gorelease: ignore .gitignored files when compiling local .zip file #37413

Open
myitcv opened this issue Feb 24, 2020 · 0 comments
Open

x/exp/cmd/gorelease: ignore .gitignored files when compiling local .zip file #37413

myitcv opened this issue Feb 24, 2020 · 0 comments

Comments

@myitcv
Copy link
Member

@myitcv myitcv commented Feb 24, 2020

What version of Go are you using (go version)?

$ go version
go version devel +151ccd4bdb Mon Feb 24 02:36:05 2020 +0000 linux/amd64
$ git rev-parse HEAD
7c80518d1cc79ffde9e571fe4fd281f321d36200

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOENV="/home/myitcv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/myitcv/gos"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/myitcv/gostuff/src/github.com/myitcv/govim/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build875262587=/tmp/go-build -gno-record-gcc-switches"

What did you do?

$ gorelease -base=v0.0.29

in a checkout of govim which is ~8MB in size at the time of writing.

What did you expect to see?

A comparison with v0.0.29 to be presented

What did you see instead?

gorelease: create zip /home/myitcv/gostuff/src/github.com/myitcv/govim: module source tree too large (max size is 524288000 bytes)

It appears that gorelease is including .gitignore-d files when creating a local zip file. It should almost certainly ignore those. Indeed gorelease should probably fail unless git status -porcelain is clean to avoid any ambiguity.

cc @jayconrod

@gopherbot gopherbot added this to the Unreleased milestone Feb 24, 2020
@jayconrod jayconrod changed the title x/exp/gorelease: ignore .gitignored files when compiling local .zip file x/exp/cmd/gorelease: ignore .gitignored files when compiling local .zip file Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants