Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: golang 1.14.rc1 3-5% performance regression from golang 1.13 during protobuf marshalling [1.13 backport] #37421

Closed
gopherbot opened this issue Feb 24, 2020 · 5 comments
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 24, 2020

@randall77 requested issue #37086 to be considered for backport to the next 1.13 minor release.

@gopherbot please open a backport issue.

I don't think this performance regression qualifies for a backport, but I'll let the release guys make that call.

@randall77
Copy link
Contributor

@randall77 randall77 commented Feb 25, 2020

Also consider for 1.14.1.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Mar 2, 2020

Also consider for 1.14.1.

Made #37613 for that.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Mar 2, 2020

@randall77 Does this backport apply to 1.13? Based on my reading of #37086 so far, it looks the problem only applies to 1.14, does it not?

@randall77
Copy link
Contributor

@randall77 randall77 commented Mar 3, 2020

Yes, sorry, this only needs to go into 1.14.1, not 1.13 or earlier.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Mar 3, 2020

Closing this because the issue doesn't apply to Go 1.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.