Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: investigate performance regression vs Go 1.13 #37429

Open
dr2chase opened this issue Feb 24, 2020 · 2 comments
Open

cmd/compile: investigate performance regression vs Go 1.13 #37429

dr2chase opened this issue Feb 24, 2020 · 2 comments

Comments

@dr2chase
Copy link
Contributor

@dr2chase dr2chase commented Feb 24, 2020

What version of Go are you using (go version)?

go1.14-almost

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

Linux, AMD64, does not have the recent Intel microcode update (does not need it as far as I can tell).

What did you do?

This is a do-not-forget performance note.
Somewhere during 1.14 development, performance of the "bent" benchmark

github.com/ethereum/go-ethereum/common/bitutil
Encoding4KBVerySparse

got worse by about 9% (it varies). According to bisection this was linked to
insertion of a dead code phase in the compiler to improve debugging output but I have not tracked down the exact cause. It could be related to branch alignment, but superficially it "makes no sense".

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Feb 25, 2020

Loading

@dmitshur dmitshur added this to the Go1.15 milestone Feb 25, 2020
@randall77 randall77 removed this from the Go1.15 milestone May 21, 2020
@randall77 randall77 added this to the Go1.16 milestone May 21, 2020
@randall77 randall77 removed this from the Go1.16 milestone Dec 14, 2020
@randall77 randall77 added this to the Go1.17 milestone Dec 14, 2020
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Apr 27, 2021

Will we have time to look at this for the 1.17 cycle? Should we move this to the Backlog milestone? Thanks.

Loading

@dr2chase dr2chase removed this from the Go1.17 milestone May 24, 2021
@dr2chase dr2chase added this to the Backlog milestone May 24, 2021
@dmitshur dmitshur changed the title cmd/compile: Investigate regression in vs 1.13 cmd/compile: investigate performance regression vs Go 1.13 Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants