Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: go/parser work-arounds #37451

Open
stamblerre opened this issue Feb 25, 2020 · 0 comments
Open

x/tools/gopls: go/parser work-arounds #37451

stamblerre opened this issue Feb 25, 2020 · 0 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Feb 25, 2020

This issue tracks all of the workarounds implemented in gopls to handle places where go/parser loses information. Most of this code can be found in golang.org/x/tools/internal/lsp/cache/parse.go and was written by @muirdm.

The current list of workarounds includes handling:

  • Missing curly braces in if statements (if foo -> if foo {})
  • Missing selectors (x. -> x._)
  • Partial identifiers that are keywords (foo.var -> foo._)
  • Missing conditional statements in if statements with initialization statements (if i := 0)
  • Unexpected array types ([]int -> []int{})
  • Incomplete go or defer statements (go foo -> go foo()).
  • Dangling selectors in go or defer statements
go foo.
y := 1

becomes

go foo._
y := 1
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Feb 25, 2020
@stamblerre stamblerre modified the milestones: gopls/v1.0.0, Unreleased Mar 12, 2020
@stamblerre stamblerre added the Thinking label Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.