Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add slowbots heuristics #37454

Open
josharian opened this issue Feb 25, 2020 · 4 comments
Open

x/build: add slowbots heuristics #37454

josharian opened this issue Feb 25, 2020 · 4 comments

Comments

@josharian
Copy link
Contributor

@josharian josharian commented Feb 25, 2020

Slowbots are awesome, but manual, and thus error-prone.

We could add some heuristics to automatically trigger appropriate slowbots. For example, any change that touches cmd/compile/internal/ssa/rewrite_ARCH.go should trigger slowbots for that arch (or set of arches). Similarly for any file named whatever_ARCH.s. Probably something similar for files named whatever_OS.go.

We could start small and improve heuristics over time. There'd be a few false positives, but probably few enough that it'd be worth it.

cc @bcmills @dmitshur

@gopherbot gopherbot added this to the Unreleased milestone Feb 25, 2020
@gopherbot gopherbot added the Builders label Feb 25, 2020
@mvdan

This comment has been minimized.

Copy link
Member

@mvdan mvdan commented Feb 25, 2020

Can I give ten thumbs up? :)

I think we could make this a bit smarter than just "did this file change at all?". For example, for Go files, we could ignore formatting and comment changes by comparing the before and after through go/format after dropping all comments. This isn't foolproof, because some relevantcomments like // +build, but this might help us with false positives.

@cagedmantis

This comment has been minimized.

Copy link
Contributor

@cagedmantis cagedmantis commented Feb 26, 2020

/cc @dmitris @toothrot

@dmitris

This comment has been minimized.

Copy link
Contributor

@dmitris dmitris commented Mar 2, 2020

fwd /cc @dmitshur

@dmitshur

This comment has been minimized.

Copy link
Member

@dmitshur dmitshur commented Mar 2, 2020

This sounds very reasonable to consider, thanks for the suggestion. There are 2 concerns to be mindful of.

Slowbots are currently very limited resources, and I want to ensure this doesn’t lead to them becoming exhausted. We can adjust things as you said, so it should be a manageable problem. Can also turn it into from automatically starting to just posting a comment with a suggestion.

Secondly, it’d be nice to prototype this first before committing to this feature. I’d like to see how much code and work it’ll take to make this happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.