Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/exp/cmd/gorelease: positional arguments should specify packages to compare #37566

Open
Tracked in #46371
jayconrod opened this issue Feb 28, 2020 · 0 comments
Open
Tracked in #46371
Assignees
Labels
FeatureRequest modules NeedsFix Tools
Milestone

Comments

@jayconrod
Copy link
Contributor

@jayconrod jayconrod commented Feb 28, 2020

Currently, gorelease compares APIs of all non-main, non-internal packages within a module. This is a sensible default.

In some cases, the API of a module's internal packages should be checked, since it's consumed by nested modules. For example, packages in cloud.google.com/go/internal are used in cloud.google.com/go/storage.

In other cases, non-internal packages should not be checked. For example, authors probably don't care about incompatible changes in packages in an experimental or unstable directory.

gorelease should accept a list of package paths or patterns as positional arguments. When specified, only these packages would be checked (main packages would still be excluded, since they can't be imported).

@jayconrod jayconrod added NeedsFix FeatureRequest modules Tools labels Feb 28, 2020
@gopherbot gopherbot added this to the Unreleased milestone Feb 28, 2020
@jayconrod jayconrod removed this from the Unreleased milestone May 25, 2021
@jayconrod jayconrod added this to the gorelease milestone May 25, 2021
@jadekler jadekler self-assigned this Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest modules NeedsFix Tools
Projects
None yet
Development

No branches or pull requests

3 participants