Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/base64: Add examples for Encode/Decode #37595

Open
shihanng opened this issue Mar 2, 2020 · 6 comments
Open

encoding/base64: Add examples for Encode/Decode #37595

shihanng opened this issue Mar 2, 2020 · 6 comments

Comments

@shihanng
Copy link

@shihanng shihanng commented Mar 2, 2020

Currently we have examples for

However, it would be nice if we can also include the example for

to demonstrate how to do the encoding/decoding to/from byte slice values.

If this is okay, I can submit a CL for review.

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Mar 2, 2020

Having examples for those two methods should be helpful.

We want to make sure the examples are high quality and demonstrate good usage. We can ensure that's the case as part of the code review.

Please feel free to send a CL. Thanks.

/cc @rsc per owners.

@dmitshur dmitshur added this to the Backlog milestone Mar 2, 2020
@shihanng
Copy link
Author

@shihanng shihanng commented Mar 2, 2020

Thanks! I will start working on this.

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 3, 2020

Change https://golang.org/cl/221857 mentions this issue: encoding/base64: add examples for Encode, Decode

hugolgst added a commit to hugolgst/go that referenced this issue Mar 23, 2020
Fixes golang#37595
hugolgst added a commit to hugolgst/go that referenced this issue Mar 23, 2020
Updates golang#37595
hugolgst added a commit to hugolgst/go that referenced this issue Mar 23, 2020
Fixes golang#37595
@gopherbot
Copy link

@gopherbot gopherbot commented Mar 23, 2020

Change https://golang.org/cl/224899 mentions this issue: encoding/base64: add examples for Encode/Decode, fixes #37595

@zaneChou1
Copy link
Contributor

@zaneChou1 zaneChou1 commented Jul 28, 2020

I am confused that the CL is abandoned without a reason and the issue is not closed.
Is it necessary to add a example for Encode ?

Change https://golang.org/cl/224899 mentions this issue: encoding/base64: add examples for Encode/Decode, fixes #37595

@shihanng
Copy link
Author

@shihanng shihanng commented Jul 28, 2020

There was another CL submitted originally #37595 (comment) and still waiting to be reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants