Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: remove darwin/386 #37610

Open
andybons opened this issue Mar 2, 2020 · 2 comments
Open

all: remove darwin/386 #37610

andybons opened this issue Mar 2, 2020 · 2 comments
Assignees
Milestone

Comments

@andybons
Copy link
Member

@andybons andybons commented Mar 2, 2020

Per #34749, we’re going to remove darwin/386 for Go 1.15. This is a tracking issue for that work.

Some affected files (taken from above issue. Thanks, @bradfitz):

./runtime/rt0_darwin_386.s
./runtime/cgo/gcc_darwin_386.c
./runtime/signal_darwin_386.go
./runtime/defs_darwin_386.go
./runtime/sys_darwin_386.s
./debug/macho/testdata/gcc-386-darwin-exec
./debug/macho/testdata/fat-gcc-386-amd64-darwin-exec
./debug/macho/testdata/clang-386-darwin.obj
./debug/macho/testdata/clang-386-darwin-exec-with-rpath
./cmd/vendor/golang.org/x/sys/unix/zsyscall_darwin_386.1_11.go
./cmd/vendor/golang.org/x/sys/unix/asm_darwin_386.s
./cmd/vendor/golang.org/x/sys/unix/zerrors_darwin_386.go
./cmd/vendor/golang.org/x/sys/unix/syscall_darwin_386.go
./cmd/vendor/golang.org/x/sys/unix/zsyscall_darwin_386.s
./cmd/vendor/golang.org/x/sys/unix/zsysnum_darwin_386.go
./cmd/vendor/golang.org/x/sys/unix/zsyscall_darwin_386.go
./cmd/vendor/golang.org/x/sys/unix/ztypes_darwin_386.go
./syscall/asm_darwin_386.s
./syscall/zerrors_darwin_386.go
./syscall/syscall_darwin_386.go
./syscall/zsyscall_darwin_386.s
./syscall/zsysnum_darwin_386.go
./syscall/zsyscall_darwin_386.go
./syscall/ztypes_darwin_386.go

But also stuff in debug/macho (see below comment), cmd/link, etc.

@andybons andybons added this to the Go1.15 milestone Mar 2, 2020
@andybons andybons self-assigned this Mar 2, 2020
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Mar 2, 2020

Just a note that I don't think we should remove any 386 support from debug/macho. The debug/macho package is for analyzing Mach-O files, and we should continue to support examining Mach-O 386 files even if we can no longer generate them.

@andybons

This comment has been minimized.

Copy link
Member Author

@andybons andybons commented Mar 2, 2020

@ianlancetaylor sgtm. Thanks for the note.

@andybons andybons assigned aclements and unassigned andybons Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.