Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: asyncPreempt should not try to save floating-point context for softfloat MIPS targets [1.14 backport] #37667

Closed
gopherbot opened this issue Mar 4, 2020 · 4 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 4, 2020

@cherrymui requested issue #37653 to be considered for backport to the next 1.14 minor release.

We probably want to backport this to Go 1.14, otherwise it will SIGILL on softfloat MIPS machines.

@gopherbot please backport this to Go 1.14. Thanks.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Mar 4, 2020

Change https://golang.org/cl/222062 mentions this issue: [release-branch.go1.14] runtime: don't save/restore FP registers in softfloat mode on MIPS(64)

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Mar 5, 2020

Approving because it is a serious problem without a workaround.

@xtaci
Copy link

@xtaci xtaci commented Mar 9, 2020

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Mar 10, 2020

Closed by merging 2e08d80 to release-branch.go1.14.

@gopherbot gopherbot closed this Mar 10, 2020
gopherbot pushed a commit that referenced this issue Mar 10, 2020
…oftfloat mode on MIPS(64)

Fixes #37667.
Updates #37653.

Change-Id: I6188e44b4bc4aba7b56f29d9ce9de4618c70fd7b
Reviewed-on: https://go-review.googlesource.com/c/go/+/222057
Run-TryBot: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 588ee79)
Reviewed-on: https://go-review.googlesource.com/c/go/+/222062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.