Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: please upgrade darwin-amd64-nocgo builders to host-darwin-10_15 #37695

Closed
bcmills opened this issue Mar 5, 2020 · 3 comments
Closed

x/build: please upgrade darwin-amd64-nocgo builders to host-darwin-10_15 #37695

bcmills opened this issue Mar 5, 2020 · 3 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Mar 5, 2020

#33041 reports a flaky test due to an apparent kernel bug on macOS 10.14 hosts.
So far, it appears that the kernel bug is not present in macOS 10.15.

The darwin-amd64-nocgo builder is currently configured to use macOS 10.14 rather than 10.15:
https://github.com/golang/build/blob/ef9e68dfbdfef06956e422b9b4dd7bec35064451/dashboard/builders.go#L2095

I would like to add a skip for the flaky test, but I don't want to skip the test on the -nocgo builder in perpetuity — I only want to skip the test on affected macOS versions. I could try to add some kind of complicated detection logic, but it seems much simpler to just upgrade the -nocgo builder to the latest host type.

CC @cagedmantis @dmitshur @toothrot @andybons

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 5, 2020

Change https://golang.org/cl/222158 mentions this issue: cmd/go/internal/renameio: skip test affected by kernel bug on macOS 10.14 builders

@cagedmantis cagedmantis self-assigned this Mar 5, 2020
@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Mar 5, 2020

Can we think of any reason not to use macOS 10.15 for the darwin-amd64-race builder as well? @toothrot @dmitshur

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 5, 2020

Change https://golang.org/cl/222238 mentions this issue: dashboard: use macOS 10.15 for race and nocgo darwin builders

gopherbot pushed a commit that referenced this issue Mar 5, 2020
…0.14 builders

The test will remain flaky on the -nocgo builder until #37695 is addressed.

Updates #37695
Fixes #33041

Change-Id: I5d661ef39e82ab1dce3a76e0e4059cf556135e89
Reviewed-on: https://go-review.googlesource.com/c/go/+/222158
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.