Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: delete insertLoopReschedChecks? #37737

Open
josharian opened this issue Mar 7, 2020 · 2 comments
Open

cmd/compile: delete insertLoopReschedChecks? #37737

josharian opened this issue Mar 7, 2020 · 2 comments
Labels
Milestone

Comments

@josharian
Copy link
Contributor

@josharian josharian commented Mar 7, 2020

We seem to have settled on signal-based pre-emption. Can we now delete the compiler code, such as the insertLoopReschedChecks pass, that is guarded by objabi.Preemptibleloops_enabled?

cc @dr2chase

@dr2chase

This comment has been minimized.

Copy link
Contributor

@dr2chase dr2chase commented Mar 8, 2020

Maybe we wait a release? I'm not sure, we've had a ton of fun with the long bug tail on signal-based preemption. I've been trying to think if we would ever want to do it the other way, for specially chosen functions or something like that (i.e., if you don't mind the performance hit, it is "safer"). Might be useful in a bare-metal world, not sure.

@zikaeroh

This comment has been minimized.

Copy link
Contributor

@zikaeroh zikaeroh commented Mar 8, 2020

Will this conflict with @aclements's comment here? #37575 (comment)

Deleting insertLoopReschedChecks seems to fall under the category of "optimizations that assume async preemption works".

@toothrot toothrot added this to the Backlog milestone Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.