Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: delete insertLoopReschedChecks? #37737

Open
josharian opened this issue Mar 7, 2020 · 3 comments
Open

cmd/compile: delete insertLoopReschedChecks? #37737

josharian opened this issue Mar 7, 2020 · 3 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone

Comments

@josharian
Copy link
Contributor

josharian commented Mar 7, 2020

We seem to have settled on signal-based pre-emption. Can we now delete the compiler code, such as the insertLoopReschedChecks pass, that is guarded by objabi.Preemptibleloops_enabled?

cc @dr2chase

@dr2chase
Copy link
Contributor

dr2chase commented Mar 8, 2020

Maybe we wait a release? I'm not sure, we've had a ton of fun with the long bug tail on signal-based preemption. I've been trying to think if we would ever want to do it the other way, for specially chosen functions or something like that (i.e., if you don't mind the performance hit, it is "safer"). Might be useful in a bare-metal world, not sure.

@zikaeroh
Copy link
Contributor

zikaeroh commented Mar 8, 2020

Will this conflict with @aclements's comment here? #37575 (comment)

Deleting insertLoopReschedChecks seems to fall under the category of "optimizations that assume async preemption works".

@toothrot toothrot added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Mar 9, 2020
@toothrot toothrot added this to the Backlog milestone Mar 9, 2020
@cristaloleg
Copy link

cristaloleg commented Dec 31, 2020

Looks like preemption is live now. Should this issue be prioritised for the next release?

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
Status: Triage Backlog
Development

No branches or pull requests

6 participants